13:43 dumbbell 

lang/rust: Update to 1.26.0

The announcement is available on Rust blog:
https://blog.rust-lang.org/2018/05/10/Rust-1.26.html

Rust 1.25.0, used as the bootstrap compiler, contains the patch from
bdrewery@ to use the compat (non-ino64) symbols on FreeBSD 12-CURRENT.
Therefore, we don't need `old_fstat.c` and the associated machinery in
the `Makefile` anymore.

 

21:35 bdrewery 

Update to 1.25.0.

- The ABI patch is no longer needed on head due to fixes being upstreamed
  to use the pre-ino64 symbols.  The ABI patch is still needed for the
  bootstrap but should be removable for 1.26.0 if it uses beta 2018-03-18.

PR:		227130 [based on]
Tested by:	dumbbell, Charlie Li
Submitted by:	riggs [based on]
Differential Revision:	https://reviews.freebsd.org/D14921 [based on]

 

13:33 dumbbell 

lang/rust: Disable "omit frame pointers"

Before the patch, the default behavior of the compiler was to omit frame
pointers. However, even though it looks fine for the code produced
by the compiler, the compiler itself was broken. When there was a
compilation error, rustc panics to report that error. While handling
that panic, it tries to unwind the stack but fails to do so, which
results in an abort(3).

Here is an example:

    $ rustc hello.rs
    error: invalid reference to argument `0` (no arguments given)
     --> hello.rs:2:5
      |
    2 |     println!("Hello {}")
      |     ^^^^^^^^^^^^^^^^^^^^
      |
      = note: this error originates in a macro outside of the current crate

    error: aborting due to previous error

    fatal runtime error: failed to initiate panic, error 5
    Abort trap (core dumped)

The problem also exists on other systems such as OpenBSD and
i686-unknown-linux-musl. "omit frame pointers" was already disabled for
i686-unknown-linux-musl:
https://github.com/rust-lang/rust/blob/88a28ff6028cf197ed6b4185d8cd4887f05e3e07/src/librustc_back/target/i686_unknown_linux_musl.rs#L22

The patch does the same for *-unknown-freebsd.

See the upstream bug for more informations:
https://github.com/rust-lang/rust/issues/43575

 

22:58 jbeich 

lang/rust: unbreak FFI for returning struct on i386

As this fixes Stylo on i386, remove the workaround in www/firefox.

PR:		223047
Suggested by:	Sebastien Marie <semarie@openbsd.org>
Approved by:	rust (dumbbell)
MFH:		2017Q4 (required by Firefox 57 scheduled on 2017-11-14)

 

15:22 vanilla 

1: Upgrade to 1.2.0.
2: add libedit to USES.

 

17:09 dumbbell 

lang/rust: Use LLVM 3.6 from Ports instead of the bundled one

Dependencies are updated: Perl is not a dependency at all and Python is
a build dependency only.

Rust may fail to build if a previous version is already installed
because the bootstrapped rustc puts "-L/usr/local/lib" at the beginning
of the linker flags. Therefore, mark rust as a CONFLICTS_BUILD with
itself.

Fix the build as a normal user by setting permissions on all directories
to 0755 [1].

Be closer to the standalone installer's file hierarchy by installing
files such as "components", "manifest-rustc" and "uninstall.sh".

Add "files/patch-src_librustc__back_target_freebsd__base.rs"
to remove "-L/usr/local/lib", "-L/usr/local/lib/gcc46" and
"-L/usr/local/lib/gcc44" from the builtin linker flags.

Differential Revision:	https://reviews.freebsd.org/D2466
Submitted by:	Chris Hutchinson [1]
Reviewed by:	jonathan, kwm
Approved by:	jonathan