06:31 lwhsu 

- Update LibreOffice to 6.0.2 [1]
- Build offline help when DOCS option enabled [2]
- Fix bad symlink and add missing dependencies [3]

PR:		224288 [1] 197071 [2] 226344 [3]
Submitted by:	Greg V <greg@unrelenting.technology> [1]
		bergerkos@yahoo.co.uk [2]
Reported by:	joneum [3]
Helped & tested by:	Daniel Ebdrup
			Greg Veldman <freebsd@gregv.net>
			Per olof Ljungmark <peo@nethead.se>
			StariKarp <starikarp@yandex.com>
			pi
Security:	289269f1-0def-11e8-99b0-d017c2987f9a

 

17:12 jkim 

Display selected VCL backend as Linux.

 

04:11 jbeich 

devel/boost-*: update to 1.66.0

Changes:	http://www.boost.org/users/history/version_1_66_0.html
PR:		223922
Exp-run by:	antoine
Differential Revision:	https://reviews.freebsd.org/D13279

 

22:40 jkim 

Catch up with liborcus 0.13.

 

16:40 tijl 

Remove unused ACLOCAL_ARGS.

 

14:41 linimon 

Mark more recently failing ports broken on aarch64.

While here, pet portlint and reformat some other BROKEN statements.

Approved by:	portmgr (tier-2 blanket)

 

19:32 zeising 

Bump portrevision to chase graphics/glew shard library version update.

PR:		223370
Submitted by:	zeising
exp-run by:	antoine
Approved by:	antoine

 

02:31 jbeich 

devel/icu: update to 60.1

Changes:	http://site.icu-project.org/download/60
ABI:		https://abi-laboratory.pro/tracker/timeline/icu4c/
PR:		223373
Exp-run by:	antoine

 

21:12 jkim 

Update to 5.3.7.

 

15:57 mat 

Remove WANT_GNOME and HAVE_GNOME.

Approved by:	bapt kwm
Sponsored by:	Absolight
Differential Revision:	  https://reviews.freebsd.org/D12643

 

00:08 jbeich 

devel/boost-*: update to 1.65.1

Changes:	http://www.boost.org/users/history/version_1_65_1.html
PR:		218835
Approved by:	maintainer timeout (1.65.1: 2 weeks; 1.65.0: 1 month)
Tested by:	jhibbits (on powerpc64, earlier version)
Exp-run by:	antoine
Differential Revision:	https://reviews.freebsd.org/D11582

 

00:05 jbeich 

devel/boost-*: enable C++11 features

PR:		218835
Obtained from:	https://github.com/DragonFlyBSD/DeltaPorts/pull/690
Approved by:	maintainer timeout (2 months)
Exp-run by:	antoine
Differential Revision:	https://reviews.freebsd.org/D11582

 

00:02 jbeich 

devel/icu: update to 59.1

- Temporarily keep C++98 working in consumers for Clang's default -std=

Changes:	http://site.icu-project.org/download/59
PR:		218788
Submitted by:	takefu@airport.fm, dcarmich@dcarmichael.net (early version)
Exp-run by:	antoine

 

20:55 gerald 

Bump PORTREVISION for ports depending on the canonical version of GCC
(via Mk/bsd.default-versions.mk and lang/gcc) which has moved from
GCC 5.4 to GCC 6.4 under most circumstances.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c++11-lib, c++11-lang,
   c++14-lang, c++0x, c11, or gcc-c++11-lib.

PR:		219275

 

18:37 jkim 

Update to 5.3.6.

 

15:49 swills 

Add missed PORTREVISION bumps after recent poppler update

 

15:36 amdmi3 

Fix verbose build (--enable-verbose no longer works) and enable it
unconditionally as per PHB SS12.10.

PR:		220356
Approved by:	maintainer timeout (office, 2 weeks)

 

13:14 jkim 

Update to 5.3.4.

 

22:21 jkim 

Attempt to fix build when WRKDIRPREFIX is defined by the user.

 

22:55 jkim 

- Turn off unit tests by default.  It is getting harder to maintain because
there are too many possible combinations with current set of build options.
Also, this significantly reduces build time.  Use TEST option to enable it.
- Implement SAL getOSVersion() for FreeBSD.  Actually, I believe it should
work with all supported UNIX-like OSes including Linux.
- Install stripped binaries.  'install-strip' target was not honored because
'distro-pack-install' target unconditionally depends on 'install' target.
- Fix couple of minor installation issues while I am here.

 

05:03 rezny 

Revision bump of all ports with USE_GL after consolidation of mesa-libs

Approved by:	swills (mentor)
Differential Revision:	https://reviews.freebsd.org/D10845

 

23:48 jkim 

Revert r441276 and properly fix build failures with JAVA option.

 

18:42 jkim 

Update to 5.3.3.

Unfortunately, support for Firebird database is temporarily disabled
because Firebird 2.5 is no longer supported.

 

18:07 jkim 

Update to 5.2.7.

 

06:48 jbeich 

devel/boost-*: update to 1.64.0

Changes:	http://www.boost.org/users/history/version_1_64_0.html
PR:		218835
Approved by:	office (bapt)
Exp-run by:	antoine
Differential Revision:	https://reviews.freebsd.org/D10472

 

21:31 kwm 

Split off the harfbuzz icu support into it's own port.

PR:		207779
Submitted by:	Vladimir Kondratyev <vladimir@kondratyev.su>
Exp-run by:	antoine@

 

20:38 bapt 

Activate the multimedia option by default

Many slideshow now have multimedia: videos, sounds, let's make the default
binary packages able to read them out of box

Approved by:	jkim@

 

15:23 gerald 

Bump PORTREVISIONs for ports depending on the canonical version of GCC and
lang/gcc which have moved from GCC 4.9.4 to GCC 5.4 (at least under some
circumstances such as versions of FreeBSD or platforms).

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using using Mk/bsd.octave.mk which in turn has USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c++11-lib, c++14-lang,
   c++11-lang, c++0x, c11, or gcc-c++11-lib.

PR:		216707

 

20:14 jkim 

Update to 5.2.6.

 

02:02 jkim 

Refine r433663.  If "use-header-bar" property of the dialog is set to TRUE,
it uses a GtkHeaderBar for action buttons instead of the action area and
gtk_dialog_get_header_bar() should not return NULL.  If it is set to FALSE,
gtk_dialog_get_header_bar() always returns NULL.  In other words, we should
not remove buttons from both header bar and action area in any case.  This
patch also removes pointless assertions from the previous patch.

PR:		203563

 

22:22 jkim 

Do not apply the kludge for PR214473 on all supported FreeBSD versions.
These patches actually reintroduced an upstream bug.

https://gerrit.libreoffice.org/22291

PR:		214473

 

18:44 jkim 

- Stop crashing when GTK3 GUI is enabled.
- Always use gtk_dialog_get_action_area().  It was available since GTK 2.14.

PR:		203563

 

22:43 jkim 

Let the users know GTK3 support is still considered experimental.

 

20:37 jkim 

Fix opening URL via xdg-open.

Submitted by:	Alexander Zagrebin (alex at zagrebin dot ru) (initial patch)

 

19:42 jkim 

- Catch up with liborcus 0.12.1.
- Make option GNOME imply GTK2 again.

 

13:20 tijl 

The output of tools like awk, date, sort, tr,... depends on the current
locale set by the user.  Add LANG=C and LC_ALL=C at the beginning of
bsd.port.mk and export them so all commands are executed with the C locale.
LC_ALL=C overrides all other LC_* variables.  LANG is used by setlocale(3)
as default value for LC_* variables, so normally it isn't used when LC_ALL
is set, but there's code out there that looks at LANG directly so it's safer
to set it as well.  The only commands not captured by this are !=
assignments before any inclusion of bsd.port.*mk.

Introduce USE_LOCALE=<locale> that adds LANG=<locale> and LC_ALL=<locale> to
CONFIGURE_ENV and MAKE_ENV so upstream build systems can be executed with a
different locale (e.g. USE_LOCALE=en_US.UTF-8).

PR:		215882
Exp-run by:	antoine
Approved by:	portmgr (antoine)

 

10:08 amdmi3 

- Remove always-true/false conditions after FreeBSD 9, 10.1, 10.2 EOL

Approved by:	portmgr blanket

 

14:43 jbeich 

textproc/hunspell: update to 1.6.0

- Restore DIST_SUBDIR from r305651
- Adjust license for "or later" clause
- Restore GPLv2+/LGPL21+ license files removed upstream as
  GPLv3+/LGPL3+ only affects Hunspell 2.0 (not currently built)
- Unbreak |make makepatch|

Changes:	https://github.com/hunspell/hunspell/releases/tag/v1.6.0
PR:		215714
Submitted by:	sunpoet (based on)
Exp-run by:	antoine
MFH:		2017Q1
Differential Revision:	https://reviews.freebsd.org/D8887

 

22:06 tcberner 

Get rid of QT_PREFIX in favour of PREFIX.

QT_PREFIX was a remnant of a bygone time.

Reviewed by:    rakuco
Approved by:    rakuco (mentor)
Differential Revision:  https://reviews.freebsd.org/D8825

 

22:24 jbeich 

textproc/hunspell: update to 1.5.4

Changes:	https://github.com/hunspell/hunspell/blob/v1.5.4/ChangeLog
PR:		214837
Exp-run by:	antoine (for 1.5.3)
Approved by:	office (bapt)

 

12:45 bapt 

Use @post[un]exec instead of deprecated @[un]exec which is deprecated

Do not bump portrevision as it does not change the final package

 

12:43 bapt 

Replace UPDATING entry by CONFLICTS_BUILD which is designed for that

Reported by:	jbeich

 

18:50 bapt 

Add bash-completion files to the package

PR:		214451
Reported by:	jbeich

 

09:45 bapt 

Update libreoffice to 5.2.3 and liborcus to 0.11.2

 

20:56 jkim 

Revert r422225 as devel/ucpp is now fixed.

 

20:25 bapt 

Use bundled ucpp at build time rather than the BROKEN devel/ucpp

Reported by:	antoine

 

08:20 tcberner 

Replace Mk/bsd.kde4.mk by Mk/Uses/kde.mk in preparation for KDE Frameworks and
Plasma5 ports

At the moment KDE ports use bsd.kde4.mk to handle their dependencies. When
working on the ports for KDE Frameworks and Plasma5 it seemed to be more
reasonable to create a new kde.mk instead of adding an bsd.kde5.mk.

The kde.mk in this review is a stripped down version of the one we are using in
the KDE Test repositories plasma5 branch [1] to only contain the parts relevant
to the current KDE4 ports in the portstree [2].

Changes to the KDE Ports needed by this:

Replace USE_KDE4 by USE_KDE [3]
Add USES=kde:4 [4]
[1] http://src.mouf.net/area51/view/branches/plasma5/KDE/Mk/Uses/kde.mk
[2] The version in the plasma5 branch also handles frameworks/plasma5 and
    handles MASTER_SITES via a KDE_DIST variable similar to bsd.qt.mk for Qt
    Ports -- I chose to leave this out for now, as the diff is already large
    enough.
[3] I chose USE_KDE instead of USE_KDE4, USE_KDE5, USE_KDEX as the version we
    want is already specified as argument to kde:<arg>
[4] For KDE Frameworks and Plasma5 ports this would be kde:5

PR:             210667
Approved by:    portmgr, mat (mentor), rakuco (mentor)
Reviewed by:    mat, rakuco
Differential Revision:   https://reviews.freebsd.org/D6961

 

04:42 jkim 

Fix build on head.

 

03:28 jkim 

Update to 5.0.6.

 

16:14 mat 

Remove USE_FIREBIRD from bsd.databases.mk, replaced by USES=firebird.

Also:
- replace USE_FIREBIRD by USES=firebird.
- convert ports depending on databases/firebird25-client directly to
USES=firebird.

PR:		208971
Submitted by:	mat
Exp-run by:	antoine
With hat:	portmgr
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D5951

 

17:48 jkim 

- Update to 1.1.0.
- Copy the previous port to devel/mdds0.

 

14:00 mat 

Remove ${PORTSDIR}/ from dependencies, categories d, e, f, and g.

With hat:	portmgr
Sponsored by:	Absolight

 

11:53 tijl 

Combine print/cups-base, print/cups-client and print/cups-image into
print/cups and update it to 2.1.3.  Also remove print/cups-pstoraster,
improve print/cups-filters, print/foomatic-* and update print/hplip to
3.16.2.

Long description:

First some background.  When you hand a file to cups it sets up a chain of
filter programs that converts the file to something a printer understands.
Each filter has a cost associated with it and cups tries to find the
cheapest chain.  Costs used to be configured in such a way that files were
first converted to PostScript.  This could then be manipulated further (e.g.
putting multiple pages on one sheet) before finally being sent to a
PostScript printer or another filter like pstoraster which produces a raster
format understood by non-PostScript printer drivers.  Nowadays most filters
have been moved from cups to cups-filters and they have been configured to
use PDF as an intermediate format instead of PostScript.

Merging of cups-base, cups-client and cups-image into print/cups:
- cups-image provides a library to work with the cups raster format.  It is
  only used to implement filters and printer drivers and these only exist
  in the context of a cups server so there's no need to separate this from
  cups-base.
- cups-client provides a library that allows applications to print via cups.
  It is possible to use the library to access a remote cups server without
  running a local cups server, but such a setup is discouraged and the
  configuration file to set this up has been marked deprecated.  It is
  better to run a local cups server and let that talk to the remote cups
  server because then you have the benefits of local job queuing in case the
  remote server is down or busy.  Given this and the fact that without
  filters cups-base is now smaller than it used to be it makes sense to
  merge the ports.  The patch also adds options IPPTOOL, DOCS and NLS which
  when disabled make the new cups package smaller than the current
  cups-client package.  Merging the ports also prevents problems with
  options like ZEROCONF being configured differently in both ports.
- print/cups was a metaport that depended on cups-base and some filters.
  There isn't really a need for such a metaport so cups-base can be renamed
  to cups.  The filters can be depended on by printer drivers such as hplip
  if they need them.

Additional changes to the new print/cups:
- Clean up the patches.  They seem to have been regenerated with post-patch
  changes included.
- Add a patch to prevent intermediate conversion to PDF when a PostScript
  file is sent to a PostScript printer when cups-filters is installed.
- Fix the PAM configuration file.
- Add a patch to let the server search /usr/local/share/ppd like on Linux so
  other ports don't have to add links to it.
- Remove ulpt(4) helper scripts.  The port uses libusb with ugen(4).
- Remove support for mDNSResponder.  cups-filters only supports Avahi.
- Combine ICONS and XDG_OPEN options into an X11 option to support WITHOUT_X11.
- Optionally depend on colord for ICC profile support.
- Various smaller changes.

Changes to print/cups-filters:
- Let the cups_browsed rc.d script depend on cupsd and avahi_daemon instead
  of LOGIN.
- Development of foomatic-filters has been moved to cups-filters so let this
  port install foomatic related files and add foomatic-filters to CONFLICTS.
- Fix location of liblouis tables.
- Add patch to fix ICC support.

Changes to print/cups-pstoraster:
This port is essentially an old version of Ghostscript plus a cups filter.
It's no longer developed.  This commit removes it and changes existing
dependencies to print/cups-filters which depends on print/ghostscript* and
includes a gstoraster filter that can handle both PostScript and PDF.

Changes to print/foomatic-db*:
Remove old MASTER_SITES and dependencies and eliminate PKGNAMEPREFIX.

Changes to print/foomatic-filters:
Install beh backend with its original name again and add cups-filters to
CONFLICTS.

Changes to print/hplip:
- Stop installing hpijs/foomatic-rip support.  This is no longer supported
  upstream.
- Stop installing hpcups PPDs.  These are now automatically generated.  The
  bundled PPDs are generated for an older version of cups.
- Rename the QT option to X11 to support WITHOUT_X11.
- Simplify the patches now that ports are installed in a staging area.
- Add a patch to set SO_REUSEPORT (next to SO_REUSEADDR) on the mDNS socket
  like avahi-daemon does.  This fixes Zeroconf support for HP network
  printers.

PR:		207746
Exp-run by:	antoine
Approved by:	portmgr (antoine)

 

19:03 jkim 

Update to 5.0.4.

 

23:43 jbeich 

math/glm: update to 0.9.7.1,1

Changes:	https://github.com/g-truc/glm/releases/tag/0.9.7.1
PR:		203181
Approved by:	maintainer timeout (83 days)

 

17:47 jkim 

Update to 5.0.3.

 

21:03 jkim 

Remove redundant PostgreSQL version restriction as we do not support 8.x.

 

21:06 jkim 

Update to 5.0.2.

 

01:13 jbeich 

Convert the rest to USE_GL

Tested by:	make describe (only touched ports)
Approved by:	portmgr blanket

 

09:24 marino 

editors/libreoffice: Limit libstdc++ check to FreeBSD

DragonFly's base libstdc++ *is* c++11 compliant, so marking LO
broken solely based on use of libstdc++ is erroneous logic.  However,
limiting the check to FreeBSD (and the OSVERSION check after it) is
legitimate, and that's what this commit does to unbreak DragonFly.
If it had just been the one check, I would have used BROKEN_FreeBSD
instead.

 

15:08 jkim 

Unset the DISPLAY environment variable to work around a CppUnit test.

 

04:45 jkim 

- Properly update icon caches when GTK2 and/or GTK3 option is set.
- Fix build when CUPS option is not set.
- Simplify and tidy up PLIST auto-generation.
- Reduce Clang 3.6 warnings.

 

21:26 jkim 

Update LibreOffice to 5.0.1.

Unfortunately, LibreOffice project completely dropped support for pre-C++11
compilers and libraries since 4.4.  Therefore, we cannot easily build it on
FeeBSD 9.x any more unless the system was rebuilt with WITH_CLANG_IS_CC and
WITH_LIBCPLUSPLUS.  If user is unable to upgrade the system for some reason,
the old port, i.e., 4.3.7, is still available from devel/libreoffice4 (with
no language packs).

 

16:06 kwm 

Update poppler to 0.34.0. [1]

Chase all users of shlib version change of libpoppler.so.

PR:		201477 [1]
Submitted by:	olivierd@ [1]

 

18:33 antoine 

Convert to USES=jpeg

 

07:02 amdmi3 

- Add CPE info

Approved by:	portmgr blanket

 

06:37 pi 

editors/libreoffice: fix build, if JAVA is selected

... which needs junit, which was updated because it no longer built,
which caused a new dependency on hamcrest.

PR:		199819
Submitted by:	danilo
Approved by:	just fix it approval

 

17:30 jkim 

Update to 4.3.7.

 

21:26 bapt 

Update icu to 55.1

 

23:05 bapt 

Make fonts repecting XDG

Xorg is now looking in ${LOCALBASE}/share/fonts by default
Xorg now accepts symlinks in etc/X11/fontpath.d (as decribed in Xserver(1))
Large cleanup on lots of font ports
All fonts are now properly dynamically generating fonts.dir and fonts.scale
instead of sometime overwriting existing ones)
All fonts are generating fontconfig's cache
Improve consistency in fonts ports

 

20:26 jkim 

- Update to 4.3.6.
- Enable GIO when GTK2 or GTK3 is enabled. [1]

Submitted by:	tijl [1]

 

12:28 kwm 

Update poppler to 0.30.0 [1].

Make sure we use openjpeg1 in poppler, while openjpeg2 support
was added there still bugs in openjpeg2 that need to be fixed.
Add patches to inkscape for API changes in poppler 0.29.0 [2].

PR:		196599 [1]
Submitted by:	olivierd@ [1]
Exp-run by:	antoine@
Obtained from:	upstream [2]

 

08:06 jkim 

Use gstreamer 1.0 instead of 0.10 for MMEDIA option.

Submitted by:	tijl

 

20:54 bapt 

Bump portrevision after png update

 

19:04 antoine 

Change libpng15.so to libpng.so in LIB_DEPENDS to prepare the upgrade

 

06:03 ohauer 

- rename www/neon29 to www/neon and update to neon-0.30.1
- adjust ports depending on neon, bump PORTREVISION

Changelog:
Fix memory leak with GnuTLS (Werner Baumann, Patrick Ohly).
Fix possible crash after DNS lookup errors on Windows (Olivier Goffart).
Don't fail if the SSL cert changes between connections with OpenSSL, behaviour
now matches that with GnuTLS.
Fix PKCS#11 support under OpenSSL with TLS 1.2.
Fix static linking with pkg-config file (Alan H)

PR:		195786
Differential Revision:	https://reviews.freebsd.org/D1319
Submitted by:	ohauer
Reviewed by:	portmgr (bapt, mat)
Approved by:	portmgr, lev (implicit)

 

23:32 jkim 

Update to 4.3.5.

 

08:12 jkim 

Update to 4.3.4.

 

12:55 makc 

Bump PORTREVISION after graphics/poppler update to 0.26.3

 

18:15 jkim 

Update to 4.3.3.

 

16:20 jkim 

Remove a stale comment after r371639.

 

17:49 jkim 

LibreOffice works fine with Java 7 and later.

PR:	194667

 

15:43 mva 

- Convert ports from dns/, editors/ and emulators/ to new
  USES=python

Approved by:	portmgr (implicit)

 

21:14 jkim 

Update to 4.3.2.

 

20:50 gerald 

Update the default version of GCC in the Ports Collection from GCC 4.7.4
to GCC 4.8.3.

Part II, Bump PORTREVISIONs.

PR:		192025
Tested by:	antoine (-exp runs)
Approved by:	portmgr (implicit)

 

17:57 crees 

Fix syntax of USES=pgsql

 

22:13 tijl 

Bump PORTREVISION on more ports that depend on libgcrypt after the update
in r363436 and remove the UPDATING entry because it did not guarantee
that all ports were updated nor that they were updated in the right order.
Also remove libgcrypt.la again.

PR:		192342
Approved by:	portmgr (implicit, bump unstaged ports)

 

18:34 tijl 

net/openldap24-*:
- Convert to USES=libtool and bump dependent ports
- Avoid USE_AUTOTOOLS
- Don't use PTHREAD_LIBS
- Use MAKE_CMD

databases/glom:
- Drop :keepla
- Add INSTALL_TARGET=install-strip

databases/libgda4* databases/libgda5*:
- Convert to USES=libtool and bump dependent ports
- USES=tar:xz
- Use INSTALL_TARGET=install-strip
- Use @sample

databases/libgdamm:
- Drop :keepla
- USES=tar:bzip2
- Use INSTALL_TARGET=install-strip

databases/libgdamm5:
- Add INSTALL_TARGET=install-strip
- Drop --enable-static (inherited from old repocopy)

devel/anjuta x11-toolkits/py-gnome-extras:
- Drop :keepla

dns/powerdns dns/powerdns-devel:
- Convert to USES=libtool
- Add INSTALL_TARGET=install-strip
- Disable static modules
- Stop creating library symlinks with .0 suffix, not needed for dynamically
  opened modules

mail/dovecot2:
- Add USES=libtool

mail/dovecot2-pigeonhole:
- Drop CONFIGURE_TARGET (incorrect for Dragonfly)
- Add USES=libtool and INSTALL_TARGET=install-strip

math/gnumeric:
- USES=libtool tar:xz

Approved by:	portmgr (implicit, bump unstaged ports)

 

17:30 jkim 

Remove an unnecessary local patch.  Originally, it was added to fix compiler
warnings and to improve performance.  The compiler warnings were fixed some
time in 4.1.x but the local patch remained for performance.  Today I was
notified by an upstream developer that it may have interoperability issues
with other dBase III implementations because the original implementation had
512-byte fixed-size blocks.  We better be safe than sorry.

 

23:14 bapt 

Chase hyphen shlib change

 

07:09 bapt 

Convert USE_PGSQL to USES=pgsql

 

02:40 jkim 

Update to 4.2.5.

 

00:12 jkim 

Shut up check-orphans.

Reported by:	swills

 

05:52 jkim 

- Fix build with libc++ on i386.
- Fix JAVA option.  A distfile was missing.
- Work around INSTALLS_ICONS issues.  Icon caches were not properly updated.
- Tidy up bash completion installation.

 

11:02 bapt 

Restore configure regeneration

 

09:26 bapt 

Some part of the build might want to run autoreconf

 

05:44 antoine 

Add missing \

 

05:38 bapt 

Add a build dependency on textproc/flex (FreeBSD 9.1 and 8 requires it)

Reported by:	antoine

 

18:47 bapt 

explicitly disable doxygen

Reported by:	pi

 

14:45 bapt 

Forgot libreoffice itself in previous commit