[ 14:03 tijl  ]

• 398996 Mk/Uses/iconv.mk
• 398996 audio/deadbeef/Makefile
• 398996 audio/deadbeef/files/patch-junklib.c
• 398996 comms/hidapi/Makefile
• 398996 comms/hidapi/files/patch-configure.ac
• 398996 comms/hidapi/files/patch-libusb-hid.c
• 398996 converters/libiconv/Makefile
• 398996 converters/libiconv/files/patch-lib-iconv.c
• 398996 deskutils/fbreader/Makefile
• 398996 deskutils/ljclive/Makefile

Remove iconv(), iconv_open() and iconv_close() symbols from libiconv.

These were FreeBSD specific aliases for libiconv(), libiconv_open() and
libiconv_close() that are now also provided by libc which complicates
writing configure tests that work correctly when both libc iconv and
libiconv are available.

Also, because the libiconv iconv.h header redefines iconv* to libiconv*
correct use of the header implies that the aliases aren't used.

The following ports needed fixes because there was something wrong with
the way they tried to detect or use iconv:

audio/deadbeef: Remove LIBICONV_PLUG from a source file.  It's a
compile-time option and should not be set in source code.

(Only the first 15 lines of the commit message are shown above )

[ 13:26 tijl  ]

• 348854 converters/libiconv/Makefile
• 348854 converters/libiconv/files/patch-lib-iconv.c

- Remove indefinite article from COMMENT.
- Enable -fvisibility=hidden.
- Add USE_CSTD=gnu89 to fix compilation with -O0 and -Oz.
- Add DOCS option.

PR:		ports/186846
Approved by:	kwm, marcus