11:06 Rene Ladan (rene) 

Tools/scripts/rmport: do not add a trailing colon when only removing one port

Reported by:	sunpoet (via private mail)

    206e629

09:39 Rene Ladan (rene) 

Tools/scripts: rmport: force cleaning up at the end

    9f5f51d

11:40 Rene Ladan (rene) 

Tools/scripts/rmport: also cleanup when being trapped on a signal

This should get rid of stale gitrmlist* and gitlog* files.

    8270a4f

11:29 Rene Ladan (rene) 

Tools/scripts/rmport: remove extraneous trailing '/' in single-port commit
messages

    3a59d52

11:18 Rene Ladan (rene) 

Tools/scripts/rmport: try to fix flow for amending the final commit

    021979f

11:14 Rene Ladan (rene) 

Tools/scripts/rmport: update copyright year

    3a48862

20:24 Rene Ladan (rene) 

Tools/scripts/rmport: Fix my English

Reported by:	George L. Yermulnik <yz@yz.kiev.ua>

    a3e43bd

19:42 Rene Ladan (rene) 

Tools/scripts: use a port-specific commit message if removing a single port.

This helps in `git shortlog`, replacing "cleanup: Remove expired ports" by
"category/port: Remove expired port" for a given category and port.

Reported by:	gerald

    f08b42f

11:29 Rene Ladan (rene) 

Tools/scripts: note that you should also be in sync with origin/main

    282db8d

19:57 Rene Ladan (rene) 

rmport: first check if we are in a git checkout, then check for changes.

    332b174

17:56 Rene Ladan (rene) 

rmport: use "cleanup" instead of "*/*"

    1886020

13:45 Rene Ladan (rene) 

cleanup: remove LEGAL and (support in) related tools.

LEGAL is badly maintained, LEGALlint notices quite a number of ports
which mismatch their line in LEGAL. The port itself is always leading.

* math/giacxcas: restrict RESTRICTED_FILES to giac_* only

Differential Revision: https://reviews.freebsd.org/D30061

Reviewed by:	portmgr (mat), dch, eadler, marcus

    0b673d6

20:53 Rene Ladan (rene) 

Tools/scripts/rmport: satisfy path check hook

    d674d52

08:01 Rene Ladan (rene) 

Tools/scripts/rmport: differentiate exit codes.

    d7d1f48

20:56 Rene Ladan (rene) 

rmport: ready for git

- do not remove ports immediately but store them in a temporary file
  and remove them once the script has iterated over all ports to be
  removed. This prevents failed searches. The Subversion version
  used a temporary worktree so the main tree was unaffected.
- remove a "merge" from a question, we use rebase now.
- check if INDEX is readable and exit if not

    578d48f1

15:07 Rene Ladan (rene) 

rmport: fix and simplify workflow

- gather information about the deleted port for the commit message
  before removing the port. I somehow missed that when testing the
  script.
- Instead of a temporary branch, just operate on the current branch
  and incorporate upstream changes with git pull --rebase. This
  prevents one from being stranded on a temporary branch if the
  script crashes and oblivates the need for a squash merge [1]

Suggested by:	mat [1]

    6d299fa

10:39 Rene Ladan (rene) 

Tools/scripts/rmport: convert workflow to git.

Do not push the final result automatically yet, unlike its previous
Subversion version.

Reviewed by:	emaste, mat, uqs
Approved by:	crees (maintainer, implicit)
Differential Revision:	https://reviews.freebsd.org/D29451

    297cd65

22:54 rene 

rmport: fix and speed up the find_expired() function.

find_expired() is used with -F (report on all expired ports using the
format "date category/port: reason") and -a (remove all expired ports).

Some speedups:
- only calculate the deprecation reason for -F
- use nested loops instead of nested recursion for traversing all ports.
  The nested recursion would also stop after finding the first port.

Approved by:	maintainer (crees) (implicit, fixit)

 

21:51 rene 

rmport: correctly deal with expired ports when the -a (find all expired) option.

Instead of grepping port Makefiles for EXPIRATION_DATE, evaluate this variable
using make. Also find ports by evaluating SUBDIR recursively instead of using
find on Makefile\*

Submitted by:   crees (maintainer)
Approved by:    crees (maintainer)

 

15:09 crees 

Revert flavour support.

Submitted by:	rene

 

14:54 crees 

Support flavor_EXPIRATION_DATE

Correctly ignore commented dates (why would that exist?)

Handle more neatly when EXPIRATION_DATE is not in the main Makefile

 

13:40 rene 

rmport: if the user edited the commit message, ask again afterwards.

This is in line with asking for recreating the diffs and "fixes" the workflow.

 

09:20 rene 

rmport: usability fixes:
- only write the message to edit the log once
- show the log itself instead of the temporary filename

 

11:30 rene 

Tools/scrips/rmport: improve usability

- if svn is not found, look for svnlite
- improve workflow of removing ports

Submitted by:	blackend via email
Approved by:	maintainer (crees)

 

16:29 eugen 

rmport: provide default for EDITOR varialble to prevent
an error "svnlog: not found" when EDITOR is undefined.

Reported by:	Matthias Fechner <idefix@fechner.net>
Approved by:	portmgr (crees)

 

16:55 rene 

Detect flavored dependencies in Tools/scripts/rmport and add myself to the
copyright.

 

17:45 ler 

Update Tools/scripts/rmport to ignore commented out EXPIRATION_DATE lines

Reviewed by: 	crees (maintainer)
Approved by:	rene (portmgr, mentor), adamw (portmgr, mentor), crees (maintainer)
Differential Revision:	https://reviews.freebsd.org/D10548

 

17:53 rene 

Remove a stale comment in Tools/scripts/rmport

 

17:51 rene 

As a frequent user of the rmport script, it was time for some improvements:
- allow PORTSDIR to be a symbolic link when looking for expired ports or
  dependent ports
- allow for trailing slashes when specifying ports as cat/name. This prevents
  the port being a false positive for itself when the Makefile mentions the
  port name (e.g., in PLIST_FILES)
- fetch possibly open PRs via Bugzilla, GNATS is long gone. Remove the
  version that used freefall. Thanks to crees for pretty-printing the results.
- forcibly delete the temporary checkout to prevent rm(1) from asking for
  confirmation on each file in .svn
- add myself as author

Approved by:	maintainer (crees)
Differential Revision:	https://reviews.freebsd.org/D6396

 

15:31 naddy 

Default to repo.FreeBSD.org for commits, as urged by our repo meister.

Approved by:	crees

 

20:30 crees 

Fix cdiff

Reported by:	swills

 

23:49 bapt 

Make check_deps behave the same as check_PRs:
propose to skip removing a port if anything depends on it, instead of infinite
looping on "ignore the issue"

 

17:56 eadler 

Make the removal diff nicer to read by not showing the line-by-line removal and
instead replace it with "FILE has been deleted"

Reviewed by:	crees

 

20:57 svn2cvs 

SVN rev 300901 on 2012-07-15 20:57:22Z by beat

- Update addport and rmport to work with Subversion

Submitted by:   crees, miwi

20:57 beat 

- Update addport and rmport to work with Subversion

Submitted by:	crees, miwi

18:32 crees 

Take maintainership-- thanks to vd for his past work on this script

Approved by:    vd (maintainer)

- Make the diff output work

- Use cdiff if exists, otherwise stick with $EDITOR

- Stop trying to remove CVSROOT; hasn't been checked out since modules
  support was removed by erwin

00:48 glarkin 

- Fixed "permission denied" error
- Prevented full ports tree build when operating with ~/.cvsrc

PR:             ports/139121

22:09 erwin 

CVSROOT/modules no longer contains an entry per port, remove support
for this from these scripts.

20:39 vd 

Use echo instead of printf because external commands cannot be executed
with very long arguments (>400000 characters).

The problem reveals for example if
/usr/ports/Tools/scripts/rmport -d print/ghostscript-gnu
is executed - it does
printf "%s\n" "... 451109 chars ..."

Spotted by:     rafan

07:24 vd 

* Run cvs update just before cvs commit to sync a potentially changed files
  in the repository. Suggested by: gabor@
* Fix typo in the output

14:25 vd 

A bunch of cosmetic changes - add one empty line to make the output more
readable and use double quotes everywhere.

10:19 vd 

Make output messages more useful

15:49 vd 

* Make it possible to skip existing dependencies and ports references in LEGAL
  and continue with removal anyway. Requested by miwi@
* Pipe dependencies information (if any) through a PAGER because INDEX lines
  are very long and hard to read when wrapped

13:18 vd 

Query Gnats for PRs by using the query-pr command on freefall instead of the
web-interface becase the later is not reliable.

07:32 vd 

Add check for existing non-closed PRs related to the port being removed.
If any are found then ask if the port should be skipped from removal or
removed regardless of the PRs.

09:20 vd 

Add deprecated reason to the output of -F

09:57 vd 

* Create custom commit message template and populate it with the ports
  to be removed, possibly with the expiration date and deprecated reason
* If port is not marked for expiration than put "Removed" in ports/MOVED
  entry instead of "Has expired"
* Implement -a option to remove all expired ports
* Ask if the cvs diff output should be recreated/reviewed again thus
  giving the committer a chance to edit files by hand and view diff
  results afterwards
* Cosmetic changes

10:40 vd 

When checking for dependencies of foocategory/barport also find constructs
like .../barport/something e.g. expect either space, slash or eol after
port's name

09:13 vd 

When checking dependencies also look for portname references in Mk/*.mk
in addition to */*/Makefile* and ignore references in comments

08:35 vd 

Remove grep's -w switch from the dependency check since it misses some
dependencies. This needs some more polishing but for now it is better to
emit false positives than skip dependencies.

08:31 vd 

Escape characters (like +) that may appear in ports' names and
break sed -E regular expressions

11:31 vd 

Add support for specifying ports to be removed as directories on the
filesystem (either absolute or relative) in addition to `category/port'.

PR:             ports/96649
Submitted by:   Cheng-Lung Sung <clsung@freebsd.org>
Reworked by:    vd

09:16 vd 

Improve dependency check:
When removing category/port - look if other ports' Makefiles contain
`/port' rather than `category/port', since the later misses things
like `${.CURDIR}/../port'

08:08 vd 

Add support for removing multiple ports which depend on each other

05:23 vd 

Quote ${1} so we don't get ``[: =: unexpected operator'' if the script
is started without arguments.

05:54 vd 

Add the script I use to remove ports so everyone
can benefit (or suffer :-) from it.