non port: Mk/Scripts/functions.sh |
SVNWeb
|
Number of commits found: 28 |
Tue, 6 Apr 2021
|
[ 14:27 Mathieu Arnold (mat) ] 5d33e04 (Only the first 10 of 224 ports in this commit are shown above. )
framework: Remove $FreeBSD$
Where appropriate fiddle with a few other things.
|
Tue, 27 Aug 2019
|
[ 08:52 bapt ]
Prevent globbing before validating env vars.
Submitted by: dillon
Obtained from: dports (dragonfly)
|
Sun, 30 Jun 2019
|
[ 23:02 bdrewery ]
Reduce code duplication from r504140.
Suggested by: cem
Sponsored by: DellEMC
|
Thu, 13 Jun 2019
|
[ 22:22 bdrewery ]
parse_plist: Avoid excess fork+exec inside the loop for stripping (mode) lines.
Need to do it still after stripping away @comment though.
The @dir handling could probably be improved as well somehow.
|
Fri, 8 Jun 2018
|
[ 09:26 mat ]
SC2046: Quote this to prevent word splitting.
When command expansions are unquoted, word splitting and globbing will
occur. This often manifests itself by breaking when filenames contain
spaces.
Trying to fix it by adding quotes or escapes to the data will not work.
Instead, quote the command substitution itself.
If the command substitution outputs multiple pieces of data, use a loop
instead.
Add an exception when using set -- where splitting is intended.
PR: 227109
Submitted by: mat
Exp-run by: antoine
Sponsored by: Absolight
|
Fri, 1 Jun 2018
|
[ 16:20 mat ]
SC2163: Exporting an expansion rather than a variable.
export takes a variable name, but shellcheck has noticed that you give
it an expanded variable instead. The problematic code does not export
MYVAR but a variable called foo if any.
Add exception when using indirections where the variable to extract is
actually the value of the variable.
PR: 227109
Submitted by: mat
Sponsored by: Absolight
|
[ 16:20 mat ]
SC2034: <some var> appears unused. Verify it or export it.
Variables not used for anything are often associated with bugs, so
ShellCheck warns about them.
PR: 227109
Submitted by: mat
Sponsored by: Absolight
|
[ 16:20 mat ]
SC2145: Argument mixes string and array. Use * or separate argument.
The behavior when concatenating a string and array is rarely intended.
The preceeding string is prefixed to the first array element, while the
succeeding string is appended to the last one. The middle array elements
are unaffected.
For example, with the parameters foo,bar,baz, "--flag=$@" is equivalent
to the three arguments "--flag=foo" "bar" "baz".
PR: 227109
Submitted by: mat
Sponsored by: Absolight
|
Tue, 13 Mar 2018
|
[ 21:43 bdrewery ]
Add PORTS_ENV_VARS caching support to USES=objc.
Approved by: portmgr (implicit)
|
Sat, 3 Mar 2018
|
[ 01:18 bdrewery ]
Avoid double exporting PORTS_ENV.
Approved by: portmgr (implicit)
|
Wed, 28 Feb 2018
|
[ 19:34 bdrewery ]
Add compiler.mk to PORTS_ENV.
This only handles the default CC=cc but is enough to significantly improve
INDEX/Poudriere ports var gathering due to reducing around a dozen cc
fork+exec for every port that all have the same result. These values
are reused during the port build as well which reduces more fork+exec
contention there.
Approved by: portmgr (implicit)
|
[ 18:38 bdrewery ]
ports_env: Store list of variables to export in PORTS_ENV_VARS in mk files.
This will avoid renamed/removed variables being orphaned, and allows for
exporting variables in ports_env that are not wanted to be exported in
sub-makes via _EXPORTED_VARS.
Approved by: portmgr (implicit)
|
[ 18:34 bdrewery ]
Chase r459584: Remove _PYTHON_DEFAULT_VERSION.
Approved by: portmgr (implicit)
|
Fri, 17 Feb 2017
|
[ 22:22 bdrewery ]
ports_env: Fix OPSYS not being exported.
This was causing excessive 'uname -s' executions during Poudriere dependency
calculations. The reasoning is due to HAVE_COMPAT_IA32_KERN having a newline
quoted at the end of it as '\ ' by bmake:
# make -f Mk/bsd.port.mk -V 'HAVE_COMPAT_IA32_KERN=${HAVE_COMPAT_IA32_KERN:Q}'
| cat -v
HAVE_COMPAT_IA32_KERN=YES\
This resulted in the following being executed:
export HAVE_COMPAT_IA32_KERN="YES OPSYS=FreeBSD"
With hat: portmgr
|
Mon, 5 Sep 2016
|
[ 19:23 tijl ] (Only the first 10 of 303 ports in this commit are shown above. )
- Replace Mk/bsd.linux-apps.mk and Mk/bsd.linux-rpm.mk with
Mk/Uses/linux.mk.
- Replace USE_LINUX=yes with USES+=linux and USE_LINUX=(.*) with
USES+=linux:\1 in all ports.
- Replace USE_LINUX_APPS with USE_LINUX in all ports.
- Use INSTALL_SCRIPT instead of INSTALL_PROGRAM to install scripts in some
ports.
- When USE_LINUX_RPM is defined, simplify the way DISTFILES and EXTRACT_ONLY
are defined.
- Remove BRANDELF_DIRS and BRANDELF_FILES handling. In the very rare cases
that it is still necessary ports can run ${BRANDELF} from post-patch.
- Remove AUTOMATIC_PLIST handling. Only one port used it.
- Fix Linux MASTER_SITES.
- Replace OVERRIDE_LINUX_BASE_PORT and OVERRIDE_LINUX_NONBASE_PORTS with
default versions framework. (Only the first 15 lines of the commit message are shown above )
|
Fri, 24 Jun 2016
|
[ 05:03 bdrewery ]
Add a function port_var_fetch() for fetching multiple variables from a port.
This is taken from Poudriere (uncommitted)
|
Wed, 25 May 2016
|
[ 18:46 bapt ]
Fix make check-plist with new @xmlcatmgr keyword
|
[ 15:58 mat ]
Extract the larger bsd.port.mk targets into separate scripts.
Refactor all the fetch code so that there are not 6 slightly different
versions of it but one that does it all.
The targets that have been extracted are:
- check-vulnerable
- do-fetch
- fetch-list
- fetch-url-list-int
- fetch-urlall-list
- checksum.
- makesum.
- check-checksum-algorithms
(Only the first 15 lines of the commit message are shown above )
|
Fri, 25 Dec 2015
|
[ 21:55 antoine ]
Do not cache PYTHON_PORTVERSION, it is not invariant between ports
|
Mon, 9 Nov 2015
|
[ 18:52 bdrewery ]
Fix partial tree checkouts with 'all-depends-list', 'make clean', etc, after
inclusion of the ports_env feature into that handling around r399791.
With hat: portmgr
Reported by: ian, lev
|
Mon, 19 Oct 2015
|
[ 21:10 bdrewery ]
Avoid redundantly looking up python command executions for dependency
calculation.
This gets all-depends-list in x11/kde4 down to 30 seconds after the 52->41
second improvement in r399703.
With hat: portmgr
|
[ 20:53 bdrewery ]
Avoid redundantly looking up perl version when looking up dependencies or in
sub-makes.
With hat: portmgr
|
Tue, 13 Oct 2015
|
[ 00:03 bdrewery ]
Follow-up r399170 with a script, ports_env.sh, that can be used for the purpose.
This will allow Poudriere to know if it is possible to use the feature or not
by the existence of the file.
Also fix quoting issues.
With hat: portmgr
|
Mon, 12 Oct 2015
|
[ 23:41 bdrewery ]
Add a function to export vars that bsd.port.mk generates from fork/exec.
This will be useful in Poudriere to avoid needless fork/exec for every
port when gathering dependencies.
Example usage:
MAKE=make sh -c '. Mk/Scripts/functions.sh; export_index_env; export
PACKAGE_BUILDING=1; truss -f make -C sysutils/zfstools -V BUILD_DEPENDS 2>&1' |
grep exec
This eliminates 14 exec/fork calls for this example, when PACKAGE_BUILDING
is also set during -V.
Care should be taken with UID not being passed down into actual builds as it
may conflict with non-root builds.
With hat: portmgr
|
[ 13:33 amdmi3 ]
Use -r flag for read command, this fixes handling of paths containing
backslashes, and, in result, stage-qa for archivers/deco
Approved by: portmgr (antoine)
Differential Revision: D3862
|
Sat, 26 Sep 2015
|
[ 12:13 bapt ]
Extend @sample to accept arguments
Maintainers can now use @sample sample_file target_file for all cases
that does not fall into the usual @sample something.sample
Reviewed by: antoine
Differential Revision: https://reviews.freebsd.org/D3734
|
Wed, 1 Jul 2015
|
[ 20:08 bapt ]
Factorize the function to validate env
Reviewed by: antoine
Differential Revision: https://reviews.freebsd.org/D2966
|
Thu, 8 Jan 2015
|
[ 04:04 bdrewery ]
- Move parse_plist() into a new file, functions.sh.
With hat: portmgr
|
Number of commits found: 28 |